838021 - [Dialer][User Story] Call Log number addition to existing contact

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Dialer-007

User Story:
As a user, I want the ability to add a number to an existing contact from the Call Log screen.

Comment 1

[Dylan Oliver [:doliver]]

This almost works now, but it looks like if your existing contact already has a phone number, it gets overwritten with the new number instead of added as an additional number.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

This case works for me, the new number will be added as an additional number.

Mark as qawanted to see if anyone encountered the same issue as Dylan in Comment 1.

Thanks.

Comment 3

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys, we are currently discussing with Ayman how we should proceed in the case no contact exist in the Contact List, regarding the behavior of the "Add to an existing contact" option. If you try it right now, you'll see it is wrong, I mean, the Contacts tab is shown but there is no contact to select and even the "plus" icon to add a new contact is hidden (not the text and arrow which points to it ;-999). We'll keep you posted! ;-)

Comment 4

[Germán Toro del Valle (:gtorodelvalle)]

BTW, apart from this case, it works for me as Rudy mentions in https://bugzilla.mozilla.org/show_bug.cgi?id=838021#c2 ;-)

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

In fact, Alberto just told me that "there's a bug for that"... :-p bug 828732

Comment 6

[ayman maat :maat]

Attachment: Proposed UX solution to 838021

Proposed UX solution to 838021

Comment 7

[Casey Yee]

I think the only thing I would suggest is that the Number on the call log list should come first rather than "Unknown".

Otherwise the solution looks good!

Comment 8

[Casey Yee]

Comment 7 also applies to spec bug #838020 where the solution is also posted.

Comment 9

[ayman maat :maat]

(In reply to Casey Yee [:cyee] from comment #7)
> I think the only thing I would suggest is that the Number on the call log
> list should come first rather than "Unknown".
> 
> Otherwise the solution looks good!

Hi Casey. Thanks for your feedback. Could I ask you to illustrate your IA/UX reasoning that sits behind your suggestion as per German's request in 838021. The specified IA is premeditated based on the content of the given contact's entry in the contact list. It would therefore be helpful to have an understanding of the reasoning for moving away from this. Thanks

Comment 10

[alberto.pastor]

Already fixed by Bug 838020:

https://github.com/mozilla-b2g/gaia/commit/9f666a3647abfe029eac8feada167d28d990db0c

Comment 11

[Casey Yee]

(In reply to ayman maat :maat from comment #9)
> (In reply to Casey Yee [:cyee] from comment #7)
> > I think the only thing I would suggest is that the Number on the call log
> > list should come first rather than "Unknown".
> > 
> > Otherwise the solution looks good!
> 
> Hi Casey. Thanks for your feedback. Could I ask you to illustrate your IA/UX
> reasoning that sits behind your suggestion as per German's request in
> 838021. The specified IA is premeditated based on the content of the given
> contact's entry in the contact list. It would therefore be helpful to have
> an understanding of the reasoning for moving away from this. Thanks

It's already obvious that a phone number alone doesn't have a contact associated with it.  "Unknown" doesn't offer the user any more information and just looks ugly as a empty state.   It also doesn't help readability.

Comment 12

[Casey Yee]

Attachment: Bug 838021 proposed call log entry format.

Comment 13

[Casey Yee]

Re-opening, We have not come up with a agreed UX conclusion yet.

Comment 14

[Maria Angeles Oteo (:oteo)]

(In reply to Casey Yee [:cyee] from comment #13)
> Re-opening, We have not come up with a agreed UX conclusion yet.

This US has been implemented so I am marking it as Resolved again.

What you are describing is a potential problem of the format of the call log that it's not what this US is about. 

By the way, as German commented you in bug 838020, comment 6, this behaviour you believe it's wrong it was already fixed a long time ago in Gaia.

Casey, please can you check what it's already implemented in Gaia master and open a follow-up bugs in case you detect anything wrong?

Thanks a lot

Comment 15

[Eric Pang [:epang] UX]

Attachment: Adding a new number from the call log

The visual style of this page should be the same as when choosing an image for a contact. See attached image for the mock up.

Comment 16

[Sergi]

(In reply to Eric Pang [:epang] from comment #15)
> Created attachment 720883 [details]
> Adding a new number from the call log
> 
> The visual style of this page should be the same as when choosing an image
> for a contact. See attached image for the mock up.

Right now we only have 1 building block to display the "Action Menu (https://wiki.mozilla.org/Gaia/Design/BuildingBlocks#Action_Menu). 

IMHO the incorrect screen is the one we're using right now when choosing an image. We should not be using a title over the list buttons, but the title header we are using now to add a phone number.

This is a Building Block issue and it seems we're using an old version of the Action Menu in the image selection flow. I recommend to close this bug and open a new one to update the BB in the image selection action menu.

Comment 17

[Germán Toro del Valle (:gtorodelvalle)]

Hi guys! I can confirm that in the Communications app we are currently using the Building Block mentioned by Sergi to show the action menu (the one about creating a new contact, adding to an existing contact and so on) ;-)

Comment 18

[Maria Angeles Oteo (:oteo)]

Attachment: Acceptance Criteria for US 838021

Comment 19

[John Ford [:jhford] CET/CEST Berlin Time]

per comment 10 in this bug and bug 838020#c18, this is fixed with 

https://github.com/mozilla-b2g/gaia/commit/a78ebf426840b5ef08c0cc3e437ad30aba3e2528

Comment 20

[Jason Smith [:jsmith]]

I think TEF is owning testing here.

Tony - Do we know who owns adding test cases for this?

Comment 21

[Maria Angeles Oteo (:oteo)]

The testing of this US owns to TEF team, they are preparing the test plan for it

Comment 22

[Maria Angeles Oteo (:oteo)]

Attachment: Acceptance criteria for US 838021

Comment 23

[John Hammink]

Unfortunately the testcase in moztrap cannot be run as is (ambiguous instructions).  Removing the original case and renomming for in-moztrap?

Comment 24

[John Hammink]

Fixed and + ing.